hsyuan commented on a change in pull request #1602: [CALCITE-3531]
AggregateProjectPullUpConstantsRule should not remove …
URL: https://github.com/apache/calcite/pull/1602#discussion_r349701137
##########
File path: core/src/main/java/org/apache/calcite/sql/SqlOperator.java
##########
@@ -908,15 +908,15 @@ public SqlMonotonicity
getMonotonicity(SqlOperatorBinding call) {
}
/**
- * @return true iff a call to this operator is guaranteed to always return
+ * @return true if a call to this operator is guaranteed to always return
* the same result given the same operands; true is assumed by default
*/
public boolean isDeterministic() {
return true;
}
/**
- * @return true iff it is unsafe to cache query plans referencing this
+ * @return true if it is unsafe to cache query plans referencing this
Review comment:
iff means `if and only if`. So it is ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
