hsyuan commented on a change in pull request #1557: [CALCITE-3473] Getting
unique result for table scan should contain key column(s)
URL: https://github.com/apache/calcite/pull/1557#discussion_r350398056
##########
File path: core/src/main/java/org/apache/calcite/plan/RelOptAbstractTable.java
##########
@@ -97,6 +97,11 @@ public boolean isKey(ImmutableBitSet columns) {
return false;
}
+ // Override to get unique keys
+ public List<ImmutableBitSet> getKeys() {
+ return null;
Review comment:
Should we consider giving it empty list instead of null?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
