amaliujia commented on a change in pull request #1596: [Document] Add guidance 
of how to run gradle command(e.g. check) in a
URL: https://github.com/apache/calcite/pull/1596#discussion_r350467940
 
 

 ##########
 File path: site/_docs/howto.md
 ##########
 @@ -99,6 +99,9 @@ $ ./gradlew spotlessCheck checkstyleAll # report code style 
violations
 
 You can use `./gradlew assemble` to build the artifacts and skip all tests and 
verifications.
 
+You might find these two links about Gradle are useful: [Gradle five 
things](https://docs.gradle.org/current/userguide/what_is_gradle.html#five_things)
 
 Review comment:
   Thanks for suggestion. I reformulated as suggested.
   
   Regarding to moving it to `Gradle vs Gradle wrapper`: my intention to add 
this new pieces because I tried to run `./gradlew check` locally but it failed 
to run some modules's tests locally. So I spent time to research how to run 
`:core`'s check only, which I thought might be useful tip for more people who 
cannot run a full check locally. So seems to me that these new pieces are more 
relevant here (which shares some common commands to developers).
   
   @zabetak if you think it still better to be moved to `Gradle vs Gradle 
wrapper`, I can change it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to