DonnyZone commented on a change in pull request #1605: [CALCITE-3536] Wrong
semantics in CoalesceImplementor
URL: https://github.com/apache/calcite/pull/1605#discussion_r350543101
##########
File path:
core/src/main/java/org/apache/calcite/sql/fun/SqlCoalesceFunction.java
##########
@@ -29,12 +29,21 @@
import org.apache.calcite.sql.validate.SqlValidator;
import org.apache.calcite.util.Util;
+import com.google.common.annotations.VisibleForTesting;
+
import java.util.List;
/**
* The <code>COALESCE</code> function.
*/
public class SqlCoalesceFunction extends SqlFunction {
+
+ /**
+ * Only used for testing.
+ */
+ @VisibleForTesting
+ public static boolean enableRewriteCall = true;
Review comment:
Is it necessary to disable the rewriting logic? I have impression that there
are some test cases that can shot the `CoalesceImplementor`. Maybe you can try
to remove it from `RexImpTable` and run tests to find out the ones.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
