jinxing64 commented on a change in pull request #1604: [CALCITE-3521]
CalciteSystemProperty failed to load config file
URL: https://github.com/apache/calcite/pull/1604#discussion_r350578290
##########
File path:
core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java
##########
@@ -368,9 +369,11 @@
private static Properties loadProperties() {
Properties saffronProperties = new Properties();
+ ClassLoader classLoader = MoreObjects.firstNonNull(
+ Thread.currentThread().getContextClassLoader(),
+ CalciteSystemProperty.class.getClassLoader());
// Read properties from the file "saffron.properties", if it exists in
classpath
Review comment:
Since context ClassLoader is customizable, what if it's not null but
saffron.properties can only be loaded from
`CalciteSystemProperty.class.getClassLoader()` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
