amaliujia commented on a change in pull request #1605: [CALCITE-3536] Wrong semantics in CoalesceImplementor URL: https://github.com/apache/calcite/pull/1605#discussion_r350895613
########## File path: core/src/test/java/org/apache/calcite/test/enumerable/EnumerableCalcTest.java ########## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.calcite.test.enumerable; + +import org.apache.calcite.sql.fun.SqlStdOperatorTable; +import org.apache.calcite.test.JdbcTest; + +import org.junit.Test; + +/** + * Unit test for + * {@link org.apache.calcite.adapter.enumerable.EnumerableCalc} + */ +public class EnumerableCalcTest extends AbstractEnumerableTest { + + /** + * Test case for + * <a href="https://issues.apache.org/jira/browse/CALCITE-3536";>[CALCITE-3536] + * Wrong semantics in CoalesceImplementor</a>. + */ + @Test public void testCoalesceWithoutWriting() { + tester(false, new JdbcTest.HrSchema()) + .query("?") + .withRel( + builder -> builder + .scan("s", "emps") + .project(builder.field(4)) + .filter( + builder.call(SqlStdOperatorTable.GREATER_THAN_OR_EQUAL, + builder.call(SqlStdOperatorTable.COALESCE, + builder.field(0), builder.literal(0)), + builder.literal(500))) + .build() + ) + .planContains("" + + " public boolean moveNext() {\n" + + " while (inputEnumerator.moveNext()) {\n" + + " final Integer inp4_ = (Integer) ((Object[]) inputEnumerator.current())[4];\n" + + " if ((inp4_ != null ? inp4_.intValue() : 0) >= 500) {\n" Review comment: Ah, `if (null)` is not compiling, thanks for this fix! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
