jinxing64 commented on a change in pull request #1623: [CALCITE-3549] Lex 
config for view expanding is not supported 
URL: https://github.com/apache/calcite/pull/1623#discussion_r353192685
 
 

 ##########
 File path: 
elasticsearch/src/test/java/org/apache/calcite/adapter/elasticsearch/AggregationTest.java
 ##########
 @@ -93,17 +94,20 @@ public static void setupInstance() throws Exception {
 
         // add calcite view programmatically
         final String viewSql = String.format(Locale.ROOT,
 
 Review comment:
   See above that the connection is created with url `jdbc:calcite:lex=JAVA`, 
the lex of view sql should be consistent.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to