amaliujia commented on a change in pull request #1636: [CALCITE-3568] BigQuery,
Hive, Spark SQL dialects don't support nested aggregates
URL: https://github.com/apache/calcite/pull/1636#discussion_r354459226
##########
File path:
core/src/main/java/org/apache/calcite/sql/dialect/BigQuerySqlDialect.java
##########
@@ -108,6 +108,10 @@ public BigQuerySqlDialect(SqlDialect.Context context) {
&& !SqlTypeUtil.isNumeric(call.type);
}
+ @Override public boolean supportsNestedAggregations() {
+ return false;
Review comment:
LGTM.
I verified BigQuery by running a query and it does not support nested
aggregation. BigQuery doc also does not mention the support of this feature
(https://cloud.google.com/bigquery/docs/reference/standard-sql/aggregate_functions)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
