jinxing64 commented on a change in pull request #1619: [CALCITE-3537] Add
NothingToCalcUnifyRule to match the top of MutableCalc in SubstitutionVisitor
URL: https://github.com/apache/calcite/pull/1619#discussion_r354645408
##########
File path: core/src/main/java/org/apache/calcite/plan/SubstitutionVisitor.java
##########
@@ -1070,6 +1071,70 @@ private ScanToCalcUnifyRule() {
}
}
+ /**
+ * A {@link SubstitutionVisitor.UnifyRule} that matches a {@link MutableCalc}
+ * which has {@link MutableAggregate} as child.
Review comment:
What's going on here ?
This doc here seems not consistent with the implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
