DonnyZone commented on a change in pull request #1347: [CALCITE-3224] New
RexNode-to-Expression CodeGen Implementation
URL: https://github.com/apache/calcite/pull/1347#discussion_r355251665
##########
File path: core/src/test/java/org/apache/calcite/test/ReflectiveSchemaTest.java
##########
@@ -585,10 +585,9 @@ private void check(ResultSetMetaData metaData, String
columnName,
with.query("select \"wrapperLong\" / \"primitiveLong\" as c\n"
+ " from \"s\".\"everyTypes\" where \"primitiveLong\" <> 0")
.planContains(
- "final Long inp13_ = current.wrapperLong;")
+ "final Long input_value = current.wrapperLong;")
.planContains(
- "return inp13_ == null ? (Long) null "
- + ": Long.valueOf(inp13_.longValue() /
current.primitiveLong);")
+ "return input_value == null ? (Long) null :
Long.valueOf(input_value / Long.valueOf(current.primitiveLong));")
Review comment:
The difference is
```
old: inp13_.longValue() / current.primitiveLong)
new: input_value / Long.valueOf(current.primitiveLong)
```
We can conduct unboxing optimization before operands entering into
`BinaryImplementor`.
Thanks, let me change it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
