amaliujia commented on a change in pull request #1642: [CALCITE-3583] Support
serialized to json and deserialized from json for Exchange relation operator
URL: https://github.com/apache/calcite/pull/1642#discussion_r356326903
##########
File path: core/src/main/java/org/apache/calcite/rel/externalize/RelJson.java
##########
@@ -191,7 +191,10 @@ public RelFieldCollation toFieldCollation(Map<String,
Object> map) {
}
public RelDistribution toDistribution(Object o) {
- return RelDistributions.ANY; // TODO:
+ final Map map = (Map) o;
Review comment:
+1. That would be much clear if have a java doc to link to the corresponding
`toJason` method, in which a map Object is returned.
(did a quick search on on how to reference a method in java doc:
https://stackoverflow.com/questions/5915992/how-to-reference-a-method-in-javadoc)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
