jinxing64 commented on a change in pull request #1647: [CALCITE-3588] Support
more operators in Join condition when convert …
URL: https://github.com/apache/calcite/pull/1647#discussion_r356967208
##########
File path:
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
##########
@@ -1919,17 +1952,14 @@ private static String toSql(RelNode root, SqlDialect
dialect) {
+ "on \"t1\".\"product_id\" = \"t3\".\"product_id\" or "
+ "(\"t1\".\"product_id\" is not null or "
+ "\"t3\".\"product_id\" is not null)";
- // Some of the "IS NULL" and "IS NOT NULL" are reduced to TRUE or FALSE,
+ // Some of the "IS NULL" and "IS NOT NULL" are reduced,
// but not all.
Review comment:
Yes, it's by intention -- with this change [1], rexNodes which are
alwaysTrue or alwaysFalse is actually reduced out, rather than leave a TRUE or
FALSE in the condition.
[1]
https://github.com/apache/calcite/pull/1647/files#diff-79ccdc597ccf355912fea1a60683eea2R155
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
