Technay commented on a change in pull request #1544: [CALCITE-3415] Supports
REGEXP_SUBSTR function
URL: https://github.com/apache/calcite/pull/1544#discussion_r341209450
##########
File path:
core/src/main/java/org/apache/calcite/sql/dialect/BigQuerySqlDialect.java
##########
@@ -142,6 +149,9 @@ public BigQuerySqlDialect(SqlDialect.Context context) {
SqlSyntax.BINARY.unparse(writer, INTERSECT_DISTINCT, call, leftPrec,
rightPrec);
}
break;
+ case REGEXP_SUBSTR:
Review comment:
> Hi, @Technay , thanks so much for the PR ~
> It seems that for `REGEXP_SUBSTR` you only added a SqlFunction but does
not add any implementation yet, here is my suggestion:
>
> 1. Split this patch into 2, one is purely for `REGEXP_SUBSTR`, you can
reference
[b039b15](https://github.com/apache/calcite/commit/b039b152d8d2e91ab2ca0232ebddfc998f3bb331)
to add a implementation add test cases(for sql arguments validation, for the
runtime results)
> 2. After you finished 1, you can add a `REGEXP` dialect support for the
BigQuery, in this patch, you may not need to add a implementation, just a
extend for `SqlDialect` and unparsing is okey.
Sure. Will split this into two separate PRs. Working on this. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
