amaliujia commented on a change in pull request #1669: [CALCITE-3590] Support
SQL hints for Aggregate
URL: https://github.com/apache/calcite/pull/1669#discussion_r358978685
##########
File path: core/src/main/java/org/apache/calcite/rel/core/Aggregate.java
##########
@@ -199,9 +227,9 @@ private boolean isPredicate(RelNode input, int index) {
* Creates an Aggregate by parsing serialized output.
*/
protected Aggregate(RelInput input) {
- this(input.getCluster(), input.getTraitSet(), input.getInput(),
- input.getBitSet("group"), input.getBitSetList("groups"),
- input.getAggregateCalls("aggs"));
+ this(input.getCluster(), input.getTraitSet(), new ArrayList<>(),
Review comment:
nit: As the internal data structure is Immutable, you can use
`Collections.emptyList()` to create an ImmutableList directly that using `new
ArrayList<>()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
