DonnyZone commented on a change in pull request #1666: [CALCITE-3604] Fixing
locale error message in ExtractValue Function
URL: https://github.com/apache/calcite/pull/1666#discussion_r359195631
##########
File path: core/src/main/java/org/apache/calcite/runtime/CalciteResource.java
##########
@@ -901,8 +901,6 @@
@BaseMessage("Not a valid input for REGEXP_REPLACE: ''{0}''")
ExInst<CalciteException> invalidInputForRegexpReplace(String value);
- @BaseMessage("Illegal behavior ''{0}'' EXTRACTVALUE: document: ''{1}'',
xpath expression:"
- + " ''{2}''")
- ExInst<CalciteException> illegalBehaviorInExtractValueFunc(String
errorBehavior, String value,
- String xpath);
+ @BaseMessage("Illegal behavior in EXTRACTVALUE: xml: ''{0}'', xpath
expression: ''{1}''")
+ ExInst<CalciteException> illegalBehaviorInExtractValueFunc(String xml,
String xpath);
Review comment:
Since the exception content is not demonstrated, "Illegal behavior" may be
confusing to end-uses.
Can we keep the message style same as that of Json function, i.e., "Invalid
input for ..."? E.g.,
```
@BaseMessage("Invalid input for JSON_REMOVE: document: ''{0}'', jsonpath
expressions: ''{1}''")
ExInst<CalciteException> invalidInputForJsonRemove(String value, String
pathSpecs);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
