XuQianJin-Stars commented on a change in pull request #1699: [CALCITE-3637] Update linq4j tests upgrade from junit4 to junit5 URL: https://github.com/apache/calcite/pull/1699#discussion_r361549878
########## File path: linq4j/src/test/java/org/apache/calcite/linq4j/test/Linq4jSuite.java ########## @@ -16,17 +16,12 @@ */ package org.apache.calcite.linq4j.test; -import org.apache.calcite.linq4j.function.FunctionTest; -import org.apache.calcite.linq4j.tree.TypeTest; - +import org.junit.platform.runner.JUnitPlatform; +import org.junit.platform.suite.api.SelectClasses; import org.junit.runner.RunWith; -import org.junit.runners.Suite; -/** - * Suite of all Linq4j tests. - */ -@RunWith(Suite.class) [email protected]({ +@RunWith(JUnitPlatform.class) +@SelectClasses( Review comment: > I suggest we just drop Linq4jSuite.java file ok, Let me remove it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
