amaliujia commented on a change in pull request #1687: [CALCITE-3612] Add
TIME/TIMESTAMP WITH TIME ZONE in optimizer
URL: https://github.com/apache/calcite/pull/1687#discussion_r361551249
##########
File path:
core/src/main/java/org/apache/calcite/adapter/enumerable/RexToLixTranslator.java
##########
@@ -376,6 +394,17 @@ private Expression converterToTime(RelDataType
sourceType, Expression operand) {
BuiltInMethod.TIMESTAMP_WITH_LOCAL_TIME_ZONE_TO_TIME.method,
operand,
Expressions.call(BuiltInMethod.TIME_ZONE.method, root)));
+ break;
+ // SQL 2011 Part2 Section 4.6 General Rules 15.e
Review comment:
I didn't find "general rules" under section 4.6 (was looking at page no.36)
`SQL 2011 Part2 Section 4.6 Table 3` gives a very clear conversion table.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
