danny0405 commented on a change in pull request #1691: [CALCITE-3631] Support
SQL hints for Calc
URL: https://github.com/apache/calcite/pull/1691#discussion_r361572391
##########
File path: core/src/main/java/org/apache/calcite/rel/logical/LogicalCalc.java
##########
@@ -124,4 +138,9 @@ public static LogicalCalc create(final RelNode input,
}
variableSet.addAll(vuv.variables);
}
+
+ @Override public RelNode withHints(List<RelHint> hintList) {
+ return new LogicalCalc(getCluster(), traitSet,
+ ImmutableList.copyOf(hintList), input, program);
+ }
Review comment:
We do not need invoke `ImmutableList.copyOf(` here, the constructor of
`LogicalCalc` already did that. But in order of code safety, i think we can
keep it here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
