hsyuan commented on a change in pull request #1686: [CALCITE-3630] Improve
ReduceExpressionsRule
URL: https://github.com/apache/calcite/pull/1686#discussion_r361596696
##########
File path:
core/src/main/java/org/apache/calcite/rel/rules/ReduceExpressionsRule.java
##########
@@ -270,6 +270,8 @@ private void reduceNotNullableFilter(
} else {
call.transformTo(createEmptyRelOrEquivalent(call, filter));
}
+ // New plan is absolutely better than old plan.
+ call.getPlanner().setImportance(filter, 0.0);
Review comment:
IMHO, setImportance should be used as long as the new plan expression is
better than old one, means just replace it. Even if there can be exception
during planning, it is the fault of VolcanoPlanner, not the fault of
`setImportance`. We should fix the VolcanoPlanner if the exception happens.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
