danny0405 commented on a change in pull request #1701: [CALCITE-3580] Oracle 
EXTRACT(XML) Function Support
URL: https://github.com/apache/calcite/pull/1701#discussion_r361884894
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/sql/type/OperandTypes.java
 ##########
 @@ -231,6 +231,11 @@ public Consistency getConsistency() {
   public static final FamilyOperandTypeChecker STRING_STRING_STRING =
       family(SqlTypeFamily.STRING, SqlTypeFamily.STRING, SqlTypeFamily.STRING);
 
+  public static final SqlSingleOperandTypeChecker 
STRING_STRING_OPTIONAL_STRING =
+      family(ImmutableList.of(SqlTypeFamily.STRING, SqlTypeFamily.STRING, 
SqlTypeFamily.STRING),
 
 Review comment:
   The type should be `FamilyOperandTypeChecker`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to