amaliujia commented on a change in pull request #1707: [CALCITE-3649] Hints
should be propagated correctly in planner rules …
URL: https://github.com/apache/calcite/pull/1707#discussion_r362078465
##########
File path: core/src/main/java/org/apache/calcite/plan/RelOptUtil.java
##########
@@ -396,15 +396,60 @@ public static void verifyTypeEquivalence(
* Copy the {@link org.apache.calcite.rel.hint.RelHint}s from {@code
originalRel}
* to {@code newRel} if both of them are {@link Hintable}.
*
- * <p>The hints are filtered by the hint strategies when attaching to the
{@code newRel}.
+ * <p>The two relational expressions are assumed as semantically equivalent,
+ * that means the hints should be attached to the relational expression
+ * that expect to have them.
Review comment:
typo? maybe `expects or is expected`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
