xy2953396112 commented on a change in pull request #1709: [CALCITE-3653]
TableModify convert to Logical in ToLogicalConverter
URL: https://github.com/apache/calcite/pull/1709#discussion_r362157401
##########
File path:
core/src/main/java/org/apache/calcite/rel/logical/ToLogicalConverter.java
##########
@@ -150,6 +151,15 @@ public ToLogicalConverter(RelBuilder relBuilder) {
return LogicalCalc.create(visit(calc.getInput()), calc.getProgram());
}
+ if (relNode instanceof TableModify) {
+ final TableModify tableModify = (TableModify) relNode;
+ final RelNode input = visit(tableModify.getInput());
+ return new LogicalTableModify(tableModify.getCluster(),
tableModify.getTraitSet(),
Review comment:
Thanks for review, I think `new LogicalTableModify` and
`LogicalTableModify#create` are equivalent. but it seems like that we use
`LogicalTableModify#create` more better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
