danny0405 commented on a change in pull request #1684: [CALCITE-3627] Incorrect 
null semantic for ROW function
URL: https://github.com/apache/calcite/pull/1684#discussion_r362185314
 
 

 ##########
 File path: 
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java
 ##########
 @@ -1111,9 +1114,15 @@ private static Expression implementNullSemantics(
       default:
         throw new AssertionError();
       }
+      final Expression condition =
+          nullPolicy == NullPolicy.ALL
+          ? (list.size() < conditionalOps.size()
+              ? FALSE_EXPR
 
 Review comment:
   Replace with if else

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to