jinxing64 commented on issue #1717: [CALCITE-3667] EnumerableMergeJoin should not use take-while enumerat… URL: https://github.com/apache/calcite/pull/1717#issuecomment-570440080 Hi @vlsi Thanks a lot for comment ~ 1. Yes, the implementation is similar to `mergeJoin(...).where(...)`, the output of of `mergeJoin` is `Enumerator<TResult>`, it's hard to filter values with predicate of `Predicate2<TSource, TInner>`. That's why I implement the filtering inside of `MergeJoinEnumerator` 2. For backword compatibility, shall we keep the old method of `mergeJoin` with a default `predicate` ? How do you think ?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
