XuQianJin-Stars commented on a change in pull request #1591: [CALCITE-3510] Implement Redis adapter URL: https://github.com/apache/calcite/pull/1591#discussion_r363068744
########## File path: redis/src/main/java/org/apache/calcite/adapter/redis/RedisDataProcess.java ########## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.calcite.adapter.redis; + +import org.apache.commons.lang3.StringUtils; + +import com.fasterxml.jackson.core.JsonParser; +import com.fasterxml.jackson.databind.JsonNode; +import com.fasterxml.jackson.databind.ObjectMapper; + +import java.util.ArrayList; +import java.util.LinkedHashMap; +import java.util.List; + +import redis.clients.jedis.Jedis; + +/** + * The class with RedisDataProcess. + */ +public class RedisDataProcess { + String tableName; + String dataFormat; + String keyDelimiter; + RedisDataType dataType = null; + RedisDataFormat redisDataFormat = null; + List<LinkedHashMap<String, Object>> fields; + private Jedis jedis; + private final ObjectMapper objectMapper = new ObjectMapper(); + + public RedisDataProcess(Jedis jedis, RedisTableFieldInfo tableFieldInfo) { + this.jedis = jedis; + String type = jedis.type(tableFieldInfo.getTableName()); + fields = tableFieldInfo.getFields(); + dataFormat = tableFieldInfo.getDataFormat(); + tableName = tableFieldInfo.getTableName(); + keyDelimiter = tableFieldInfo.getKeyDelimiter(); + dataType = RedisDataType.fromTypeName(type); + redisDataFormat = RedisDataFormat.fromTypeName(tableFieldInfo.getDataFormat()); + objectMapper.configure(JsonParser.Feature.ALLOW_UNQUOTED_FIELD_NAMES, true) + .configure(JsonParser.Feature.ALLOW_SINGLE_QUOTES, true) + .configure(JsonParser.Feature.ALLOW_COMMENTS, true); + assert redisDataFormat != null; + assert dataType != null; + } + + public List<Object[]> read() { + List<Object[]> objs = new ArrayList<>(); + switch (dataType) { + case STRING: + return parse(jedis.keys(tableName)); + case LIST: + return parse(jedis.lrange(tableName, 0, -1)); + case SET: + return parse(jedis.smembers(tableName)); + case SORTED_SET: + return parse(jedis.zrange(tableName, 0, -1)); + case HASH: + return parse(jedis.hvals(tableName)); + default: + return objs; + } + } + + private Object[] parseJson(String value) { + assert StringUtils.isNotEmpty(value); + Object[] arr = new Object[fields.size()]; + try { + JsonNode jsonNode = objectMapper.readTree(value); + Object obj; + for (int i = 0; i < arr.length; i++) { + obj = fields.get(i).get("mapping"); + if (obj == null) { + arr[i] = ""; + } else { + arr[i] = jsonNode.findValue(fields.get(i).get("mapping").toString()); + } + } + } catch (Exception e) { + throw new RuntimeException("Parsing json failed: ", e); + } + return arr; + } + + private Object[] parseCsv(String value) { + assert StringUtils.isNotEmpty(value); + String[] values = value.split(keyDelimiter); + Object[] arr = new Object[fields.size()]; + assert values.length == arr.length; + try { + for (int i = 0; i < arr.length; i++) { + arr[i] = values[i] == null ? "" : values[i]; + } + } catch (Exception e) { + throw new RuntimeException(e); Review comment: > What is the purpose to catch it? can we remove the try-catch? well, can remove the try-catch. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
