DonnyZone commented on a change in pull request #1724: [CALCITE-3675] SQL to
Rel conversion is broken for coalesce on nullable field
URL: https://github.com/apache/calcite/pull/1724#discussion_r364546041
##########
File path: core/src/main/java/org/apache/calcite/sql/fun/SqlCaseOperator.java
##########
@@ -216,9 +219,7 @@ public RelDataType inferReturnType(
SqlOperatorBinding opBinding) {
// REVIEW jvs 4-June-2005: can't these be unified?
if (!(opBinding instanceof SqlCallBinding)) {
- return inferTypeFromOperands(
Review comment:
I ever noticed the comment left by Julian and made some efforts to unify
them.
But it seems to be diffcult, especially for the usage of unique fields in
`SqlCallBinding`.
Maybe we need a thorough consideration on unifying type inference in
different phases (validating/converting/runtime).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
