danny0405 commented on issue #1703: [CALCITE-2450] Normalize RexCall predicates when computing digest URL: https://github.com/apache/calcite/pull/1703#issuecomment-572882731 > @danny0405 , I don't understand what do you mean by `needs-a-final-review` label. > The change has been tested both in isolation and with the cost changes, and it behaves well. > > I've added the tests and added `try-with-resources` API which simplifies the use, and `ThreadLocal` is now `private`. > > So I'm inclined to merge the PR. The PR looks good from my side, go ahead ~
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
