jinxing64 commented on a change in pull request #1755: CALCITE-3731 : Add IF
function for BigQuery, Hive and Spark Dialects
URL: https://github.com/apache/calcite/pull/1755#discussion_r365850900
##########
File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java
##########
@@ -2392,4 +2394,15 @@ public RexNode simplifyFilterPredicates(Iterable<?
extends RexNode> predicates)
return true;
}
+ private RexNode simplifyIf(RexCall e) {
Review comment:
Shall we have a test for this in RexProgramTest ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
