vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID
returns wrong result
URL: https://github.com/apache/calcite/pull/1756#discussion_r366263800
##########
File path:
core/src/main/java/org/apache/calcite/sql/validate/AggregatingSelectScope.java
##########
@@ -108,19 +108,20 @@ private Resolved resolve() {
groupExprProjection = groupAnalyzer.groupExprProjection;
}
- final Set<ImmutableBitSet> flatGroupSets =
- Sets.newTreeSet(ImmutableBitSet.COMPARATOR);
+ final TreeMap<ImmutableBitSet, Integer> flatGroupSetCount =
Review comment:
Isn't a regular `Map` sufficient here by the way?
It does look weird that a `SortedMap` is passed as a `Map` parameter, so the
order of the entries is lost.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
