DonnyZone commented on a change in pull request #1761: [CALCITE-3737] HOP 
Table-valued Function 
URL: https://github.com/apache/calcite/pull/1761#discussion_r366745144
 
 

 ##########
 File path: 
core/src/main/java/org/apache/calcite/sql/SqlWindowTableFunction.java
 ##########
 @@ -44,28 +43,21 @@ public SqlWindowTableFunction(String name) {
         SqlFunctionCategory.SYSTEM);
   }
 
-  @Override public SqlOperandCountRange getOperandCountRange() {
-    return SqlOperandCountRanges.of(3);
-  }
-
-  @Override public boolean checkOperandTypes(SqlCallBinding callBinding,
 
 Review comment:
   Why we remove these methods? Each window table function has its own 
implementation?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to