DonnyZone commented on issue #1792: [CALCITE-3775] Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter URL: https://github.com/apache/calcite/pull/1792#issuecomment-584669334 In the respect of performance, I agree with you to argument `Schema` interface with case (in)sensitive lookups. This can benefit not only `SimpleCalciteSchema` but also `CachingCalciteSchema`. But the `Schema` interface is important to end-users. Modifying the interface may bring impact on compatibility. Moreover, I don't think the performance of adopting `NamedMap` is better than current PR's implementation's `O(n)` complexity . According to the design doc (without caching, "maintains minimal state"), `SimpleCalciteSchema` needs to construct the data structure each time.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
