hsyuan commented on a change in pull request #1799: [CALCITE-3785]
HepPlanner.belongToDag() doesn't have to use mapDigest…
URL: https://github.com/apache/calcite/pull/1799#discussion_r377961442
##########
File path: core/src/main/java/org/apache/calcite/plan/hep/HepPlanner.java
##########
@@ -500,8 +500,7 @@ private void applyRules(
/** Returns whether the vertex is valid. */
private boolean belongsToDag(HepRelVertex vertex) {
- Pair<String, List<RelDataType>> key = key(vertex.getCurrentRel());
- return mapDigestToVertex.get(key) != null;
+ return graph.vertexSet().contains(vertex);
Review comment:
This method can be removed, we can call this directly in the caller.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
