vlsi commented on a change in pull request #1794: [CALCITE-3781] HintStrategy
can specify excluded rules for planner
URL: https://github.com/apache/calcite/pull/1794#discussion_r378081870
##########
File path:
core/src/main/java/org/apache/calcite/plan/volcano/VolcanoRuleCall.java
##########
@@ -160,6 +160,11 @@ protected void onMatch() {
return;
}
+ if (isRuleExcluded()) {
+ LOGGER.debug("Rule [{}] not fired due to exclusion hint", getRule());
Review comment:
Should this be evaluated before the rule is added to the match queue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
