danny0405 commented on a change in pull request #1804: [CALCITE-3794]
RexSimplify should return early if there is no pulled up predicate when
simplifying using predicates
URL: https://github.com/apache/calcite/pull/1804#discussion_r379464940
##########
File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java
##########
@@ -1571,6 +1571,9 @@ RexNode simplifyAnd2ForUnknownAsFalse(List<RexNode>
terms,
private <C extends Comparable<C>> RexNode simplifyUsingPredicates(RexNode e,
Class<C> clazz) {
+ if (predicates.pulledUpPredicates.isEmpty()) {
+ return e;
Review comment:
What if we do not return early ? Is there any error occurs ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
