jcamachor commented on a change in pull request #1828: [CALCITE-3734] MySQL
JDBC rewrite is producing queries with CHAR with range beyond 255 (Vineet Garg)
URL: https://github.com/apache/calcite/pull/1828#discussion_r384195545
##########
File path: core/src/main/java/org/apache/calcite/sql/SqlDialectFactoryImpl.java
##########
@@ -122,7 +122,7 @@ public SqlDialect create(DatabaseMetaData
databaseMetaData) {
case "MYSQL (INFOBRIGHT)":
return new InfobrightSqlDialect(c);
case "MYSQL":
- return new MysqlSqlDialect(c);
+ return new
MysqlSqlDialect(c.withDataTypeSystem(MysqlSqlDialect.MYSQL_TYPE_SYSTEM));
Review comment:
Can we add the same for Postgres? Seems to have same problem.
Nit. Can we push after _(_ to new line?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
