chunweilei commented on a change in pull request #1818: [CALCITE-3809]
RexSimplify simplifies nondeterministic function incorrectly
URL: https://github.com/apache/calcite/pull/1818#discussion_r384493713
##########
File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java
##########
@@ -323,7 +323,7 @@ private RexNode simplifyComparison(RexCall e, RexUnknownAs
unknownAs) {
// Simplify "x <op> x"
final RexNode o0 = operands.get(0);
final RexNode o1 = operands.get(1);
- if (o0.equals(o1)) {
+ if (o0.equals(o1) && RexUtil.isDeterministic(o0)) {
Review comment:
Do you notice that RexUtil.isDeterministic check is only called when
simplifying "x <op> x"?
Will it have such a significant impact as you said? I have a doubt about it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
