julianhyde opened a new pull request #1834: [CALCITE-3823] Do not use String.replaceAll URL: https://github.com/apache/calcite/pull/1834 String.replaceAll uses regex, which is inefficient, and may not be what we want. For strings, use either String.replace; for regex use Pattern.compile().matcher().replaceAll(), being sure to store the pattern for future use. Add entries to forbidden-apis/signatures.txt to prevent people using String.replaceAll in future.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
