xndai commented on a change in pull request #1832: [CALCITE-3827] Reduce the 
time complexity of finding in-edges of a vertex in the graph
URL: https://github.com/apache/calcite/pull/1832#discussion_r385262520
 
 

 ##########
 File path: 
core/src/main/java/org/apache/calcite/util/graph/DefaultDirectedGraph.java
 ##########
 @@ -110,8 +122,8 @@ public E addEdge(V vertex, V targetVertex) {
 
   public E getEdge(V source, V target) {
     // REVIEW: could instead use edges.get(new DefaultEdge(source, target))
-    final VertexInfo<V, E> info = vertexMap.get(source);
-    for (E outEdge : info.outEdges) {
+    final VertexInfo<V, E> info = vertexOutMap.get(source);
+    for (E outEdge : info.edges) {
       if (outEdge.target.equals(target)) {
 
 Review comment:
   I am not sure I understand these numbers. So the 21.663 and 0.073 are the 
scores? What do they mean?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to