vlsi commented on issue #1839: [CALCITE-3836] The hash codes of RelNodes are 
unreliable
URL: https://github.com/apache/calcite/pull/1839#issuecomment-592712216
 
 
   TL;DR: it looks like currently there's no justification for the change :-/
   
   I'm sorry to disappoint you, but
   
   > For many JVMs, the implementation is based on the object address in the 
memory
   
   This is false.
   
   > So the hash code of an object may change
   
   This is false.
   
   > This is consistent with the previous semantics, and solves the above 
problem.
   
   The new implementation violates `equal` and `hashCode` contract :-/
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to