danny0405 commented on a change in pull request #1841: Following CALCITE-3769:
Add BindableTableScanRule into the default ru…
URL: https://github.com/apache/calcite/pull/1841#discussion_r386229661
##########
File path: core/src/test/java/org/apache/calcite/test/StreamTest.java
##########
@@ -286,12 +286,11 @@ private static String schemaFor(String name, Class<?
extends TableFactory> clazz
+ " LogicalTableScan(table=[[STREAM_JOINS, PRODUCTS]])\n")
.explainContains(""
+ "EnumerableCalc(expr#0..6=[{inputs}], proj#0..1=[{exprs}],
SUPPLIERID=[$t6])\n"
- + " EnumerableHashJoin(condition=[=($4, $5)], joinType=[inner])\n"
- + " EnumerableCalc(expr#0..3=[{inputs}],
expr#4=[CAST($t2):VARCHAR(32) NOT NULL], proj#0..4=[{exprs}])\n"
- + " EnumerableInterpreter\n"
- + " BindableTableScan(table=[[STREAM_JOINS, ORDERS,
(STREAM)]])\n"
- + " EnumerableInterpreter\n"
- + " BindableTableScan(table=[[STREAM_JOINS, PRODUCTS]])")
+ + " EnumerableHashJoin(condition=[=($4, $5)],
joinType=[inner])\n"
Review comment:
No, would fire a fix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
