vlsi commented on a change in pull request #1827: [CALCITE-3821]
RelOptUtil::containsMultisetOrWindowedAgg doesn't real…
URL: https://github.com/apache/calcite/pull/1827#discussion_r388221047
##########
File path: core/src/main/java/org/apache/calcite/plan/RelOptUtil.java
##########
@@ -3418,28 +3415,19 @@ public static RelNode projectMapping(
return projectFactory.createProject(rel, ImmutableList.of(), exprList,
outputNameList);
}
- /** Predicate for whether a {@link Calc} contains multisets or windowed
- * aggregates. */
- public static boolean containsMultisetOrWindowedAgg(Calc calc) {
- return !(B
- && RexMultisetUtil.containsMultiset(calc.getProgram())
- || calc.getProgram().containsAggs());
+ /** Predicate for if a {@link Calc} does not contain windowed aggregates. */
+ public static boolean notContainsWindowedAgg(Calc calc) {
Review comment:
This looks like a public API breakage with no clear deprecation plan.
@xndai , @hsyuan was it really intended?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
