danny0405 commented on a change in pull request #1840: [CALCITE-3753] Remove rule queue importance URL: https://github.com/apache/calcite/pull/1840#discussion_r389569220
########## File path: core/src/test/resources/sql/winagg.iq ########## @@ -431,14 +431,14 @@ join ( from "hr"."emps" window w as (partition by "deptno" order by "commission")) b on a."deptno" = b."deptno" -limit 5; +order by "deptno", ar, br limit 5; Review comment: We can not force every limit test to have an order by, can we have a more nice solution to promotion the stability, i.e. if a make this change into Flink, there would be some test fails but i would not expect to modify the queries. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
