vlsi commented on a change in pull request #1848: [CALCITE-3845] CASE WHEN 
expression with nullability CAST is considered as reduced wrongly in 
ReduceExpressionsRule
URL: https://github.com/apache/calcite/pull/1848#discussion_r389708007
 
 

 ##########
 File path: 
core/src/main/java/org/apache/calcite/rel/rules/ReduceExpressionsRule.java
 ##########
 @@ -302,6 +302,7 @@ public ProjectReduceExpressionsRule(Class<? extends 
Project> projectClass,
           Lists.newArrayList(project.getProjects());
       if (reduceExpressions(project, expList, predicates, false,
           matchNullability)) {
+        assert !project.getProjects().equals(expList);
 
 Review comment:
   Can you please add a message, so the failure looks human-readable?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to