danny0405 commented on a change in pull request #1860: [CALCITE-2970] Add 
abstractConverter only between derived and required traitset
URL: https://github.com/apache/calcite/pull/1860#discussion_r395431008
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/rel/RelNode.java
 ##########
 @@ -407,6 +407,17 @@ RelNode copy(
    */
   void register(RelOptPlanner planner);
 
+  /**
+   * Indicates whether it is an enforcer operator, e.g. PhysicalSort,
+   * PhysicalHashDistribute, etc. As an enforcer, the operator must be
+   * created only when required traitSet is not satisfied by its input.
+   *
+   * @return Whether it is an enforcer operator
+   */
+  default boolean isEnforcer() {
+    return false;
 
 Review comment:
   Should we add this default interface ? There is already a default value in 
`AbstractRelNode#isEnforcer`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to