neoremind commented on issue #1567: [CALCITE-3479] Stack overflow error thrown when running join query URL: https://github.com/apache/calcite/pull/1567#issuecomment-603262042 Reverting this PR will cause the following unit tests failed in `CsvTest` when log level is set to `DEBUG`. ``` testFilterableWhereWithNot1() testFilterableWhereWithNot2() testFilterableWhere2() testFilterableWhere3() testFilterableWhere() ``` After taking a look of some of the previous related issues, some unit tests failed as well per https://issues.apache.org/jira/browse/CALCITE-2166 ``` ScannableTableTest.testPFPushDownProjectFilterAggregateNested:279 relSubset [rel#12950:Subset#5.ENUMERABLE.[]] has wrong best cost {63.8 rows, 62.308 cpu, 0.0 io}. Correct cost is {70.4 rows, 60.404 cpu, 0.0 io} ScannableTableTest.testPFTableRefusesFilterCooperative:221 relSubset [rel#13382:Subset#2.ENUMERABLE.[]] has wrong best cost {81.0 rows, 181.01 cpu, 0.0 io}. Correct cost is {150.5 rows, 250.505 cpu, 0.0 io} ScannableTableTest.testProjectableFilterableCooperative:148 relSubset [rel#13611:Subset#2.ENUMERABLE.[]] has wrong best cost {81.0 rows, 181.01 cpu, 0.0 io}. Correct cost is {150.5 rows, 250.505 cpu, 0.0 io} ScannableTableTest.testProjectableFilterableNonCooperative:165 relSubset [rel#13754:Subset#2.ENUMERABLE.[]] has wrong best cost {81.0 rows, 181.01 cpu, 0.0 io}. Correct cost is {150.5 rows, 250.505 cpu, 0.0 io} ``` Will this problem be solved ultimately? Or will it be left out there since it won't affect much?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
