danny0405 edited a comment on issue #1859: [CALCITE-3863] Make Truncate/Round return type inference overridable through rel data … URL: https://github.com/apache/calcite/pull/1859#issuecomment-603748315 > @danny0405 This is similar to #1311 which made some of the other decimal related rules configurable using a custom type system. > > Our understanding back then was this was the recommended way. Could you please elaborate on your approach if you think this is not the right way to achieve the same. In my opinion, #1311 is very different because `+` and `-` are builtin operators and we have no way for downstream projects to replace these operators, but `Round` and `Truncate` are different, they are sql functions, and if your project has maintained the sql operators by yourself, there is a chance you just override the type inference of these two instead of the whole type system, which seems too heavy and special to customize.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
