wenhuitang commented on a change in pull request #1861: [CALCITE-3468] JDBC
adapter may generate casts on Oracle for varchar without the precision and for
char with the precision exceeding max length of Oracle
URL: https://github.com/apache/calcite/pull/1861#discussion_r398299547
##########
File path: core/src/main/java/org/apache/calcite/sql/SqlDialect.java
##########
@@ -772,16 +773,26 @@ public boolean supportsDataType(RelDataType type) {
return true;
}
- /** Returns SqlNode for type in "cast(column as type)", which might be
+ public boolean allowTypeWithUnspecifiedPrecision(RelDataType type) {
+ return true;
+ }
Review comment:
The document of this method has been added.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
