ritesh-kapoor commented on a change in pull request #1873: [CALCITE-3872]
Simplify expressions with unary minus
URL: https://github.com/apache/calcite/pull/1873#discussion_r399000029
##########
File path: core/src/test/java/org/apache/calcite/rex/RexProgramTest.java
##########
@@ -2265,8 +2265,8 @@ private void assertTypeAndToString(
checkSimplify(coalesce(gt(nullInt, nullInt), trueLiteral),
"true");
checkSimplify(coalesce(unaryPlus(nullInt), unaryPlus(vInt())),
- "+(?0.int0)");
- checkSimplifyUnchanged(coalesce(unaryPlus(vInt(1)), unaryPlus(vInt())));
+ "?0.int0");
Review comment:
Should we add more test cases which covers decimal as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
