rubenada commented on a change in pull request #1870: [CALCITE-3846]
EnumerableMergeJoin: wrong comparison of composite key with null values
URL: https://github.com/apache/calcite/pull/1870#discussion_r399106354
##########
File path:
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMergeJoin.java
##########
@@ -164,6 +165,17 @@ public Result implement(EnumerableRelImplementor
implementor, Prefer pref) {
leftResult.physType.project(joinInfo.leftKeys, JavaRowFormat.LIST);
final PhysType rightKeyPhysType =
rightResult.physType.project(joinInfo.rightKeys, JavaRowFormat.LIST);
+
+ // Generate the appropriate key Comparator (keys must be sorted in
ascending order, nulls last).
+ final List<RelFieldCollation> fieldCollations = new ArrayList<>();
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
