ritesh-kapoor commented on a change in pull request #1733: [CALCITE-3679] Allow
lambda expressions in SQL queries
URL: https://github.com/apache/calcite/pull/1733#discussion_r401334294
##########
File path:
core/src/main/java/org/apache/calcite/adapter/enumerable/RexToLixTranslator.java
##########
@@ -687,6 +690,10 @@ private Expression translate0(RexNode expr,
RexImpTable.NullAs nullAs,
Expression input = list.append("inp" + index + "_", x); // safe to share
return handleNullUnboxingIfNecessary(input, nullAs, storageType);
}
+ case LAMBDA_REF: {
+ final String name = ((RexLambdaRef) expr).getName();
+ return Expressions.parameter(typeFactory.getJavaClass(expr.getType()),
name);
Review comment:
This is important and there are test failures
`FAILURE 49.5sec, 277 completed, 1 failed, 1 skipped,
org.apache.calcite.test.CalciteSqlOperatorTest
FAILURE 83.9sec, 5925 completed, 3 failed, 104 skipped, Gradle Test Run
:core:test`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
